Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SWSS] Static LAG Support Changes rebase to master #3088

Closed

Conversation

skannan-sonic
Copy link

What I did
Static lag support changes in SWSS module
sonic-net/SONiC#1039

Why I did it
Static LAG feature will be needed in case of PXE environment and where peer end device doesnt support LACP protocol

How I verified it

UT:-
        Test cases
1       Create static port channel with static flag     pass    pass
2       verify static has option flag true or false     pass    pass
3       Add static member see the portchannel is up     pass    pass
4       verify teamd is created with round-robin option by default
pass    pass
5       Remove last portchannel member check port channel down  pass
pass
6       Remove portchannel member check port channel still up   pass
pass
7       verify teamdctl config dump     pass    pass
8       verify teamdctl state dump      pass    pass
9       shutdown the portchannel check the kernel state pass    pass
10      no shutdown the portchannel check the kernel state      pass
pass
11      "Check the show output matches the review comment
root@sonic:~# show inter port
Flags: A - active, I - inactive, Up - up, Dw - Down, N/A - not
available,
       S - selected, D - deselected, * - not synced
  No.  Team Dev       Protocol     Ports
-----  -------------  -----------
-----------------------------------------
   01  PortChannel01  LACP(A)(Up)  Ethernet16(S)
   02  PortChannel02  NONE(A)(Up)  Ethernet48(S) Ethernet64(S)
Ethernet32(S)
root@sonic:~#
12      teamnl is set to roundrobin     pass    pass
13      save and reload and verify portchannel is up    pass    pass
14      "docker restart teamd
teamd stopped
swss stopped
syncd stopped

swss started
syncd started
teamd started"  pass    pass
15      warm-reboot fails even without any port channel config  fail
16      verify teamd settles doesnt hog cpu with 100% cpu usage pass
17      "trying with static port channel config on non supported
branches
port channel will be configured as LACP."               pass

Not Supported Options
1. Min links and
2. fall back are not supported

Details if related
Patch explanation
1. static lag supported with option roundrobin.
2. tlm_teamd -> teamdctl changes to handle json dump for static lag.
3. test cases -> updated

    Why ?
    Static lag support changes in SWSS module
    sonic-net/SONiC#1039

    Patch explanation
    1. static lag supported with option roundrobin.
    2. tlm_teamd -> teamdctl changes to handle json dump for static lag.
    3. test cases -> updated

    UT:-
            Test cases
    1       Create static port channel with static flag     pass    pass
    2       verify static has option flag true or false     pass    pass
    3       Add static member see the portchannel is up     pass    pass
    4       verify teamd is created with round-robin option by default
    pass    pass
    5       Remove last portchannel member check port channel down  pass
    pass
    6       Remove portchannel member check port channel still up   pass
    pass
    7       verify teamdctl config dump     pass    pass
    8       verify teamdctl state dump      pass    pass
    9       shutdown the portchannel check the kernel state pass    pass
    10      no shutdown the portchannel check the kernel state      pass
    pass
    11      "Check the show output matches the review comment
    root@sonic:~# show inter port
    Flags: A - active, I - inactive, Up - up, Dw - Down, N/A - not
    available,
           S - selected, D - deselected, * - not synced
      No.  Team Dev       Protocol     Ports
    -----  -------------  -----------
    -----------------------------------------
       01  PortChannel01  LACP(A)(Up)  Ethernet16(S)
       02  PortChannel02  NONE(A)(Up)  Ethernet48(S) Ethernet64(S)
    Ethernet32(S)
    root@sonic:~#
    12      teamnl is set to roundrobin     pass    pass
    13      save and reload and verify portchannel is up    pass    pass
    14      "docker restart teamd
    teamd stopped
    swss stopped
    syncd stopped

    swss started
    syncd started
    teamd started"  pass    pass
    15      warm-reboot fails even without any port channel config  fail
    16      verify teamd settles doesnt hog cpu with 100% cpu usage pass
    17      "trying with static port channel config on non supported
    branches
    port channel will be configured as LACP."               pass

    Not Supported Options
    1. Min links and
    2. fall back are not supported
Copy link

CLA Missing ID CLA Not Signed

@skannan-sonic
Copy link
Author

Easy CLA issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant