[System ready] Report ready state to Sysmonitor daemon #3126
Conversation
| */ | ||
| FieldValueTuple app_state("up_status", "true"); | ||
| vector<FieldValueTuple> feature_attrs = { app_state }; | ||
| feature.set("swss", feature_attrs); |
There was a problem hiding this comment.
why is this done only from portsyncd?
There was a problem hiding this comment.
We don't have another requirement, so portsyncd is good enough.
fastiuk
force-pushed
the
dev-sysready-extension
branch
from
970b334
to
44dc7c8
Compare
|
@fastiuk please refer to the comment provided. also please update the PR description of what are you are trying to fix and the scope. if this is a bug to whihc branches it should go? |
fastiuk
force-pushed
the
dev-sysready-extension
branch
from
44dc7c8
to
0107ebe
Compare
| /* | ||
| * Notify "System ready" feature that we are ok. | ||
| */ | ||
| FieldValueTuple app_state("up_status", "true"); |
There was a problem hiding this comment.
Why is portinitdone alone considered for sysready? In case of warmboot/fastboot scenario should we consider reconciliation done as sys ready?
@dgsudharsan we don't have other requirements and portinitdone is good enough. The previous design used "boot-up" of the service as "system ready".
I am not sure about "reconciliation done". Is warmboot/fastbot not set "PortInitDone"?
| */ | ||
| FieldValueTuple app_state("up_status", "true"); | ||
| vector<FieldValueTuple> feature_attrs = { app_state }; | ||
| feature.set("swss", feature_attrs); |
There was a problem hiding this comment.
We don't have another requirement, so portsyncd is good enough.
fastiuk
force-pushed
the
dev-sysready-extension
branch
from
0107ebe
to
455d78c
Compare
Signed-off-by: Yevhen Fastiuk <yfastiuk@nvidia.com>
fastiuk
force-pushed
the
dev-sysready-extension
branch
from
455d78c
to
91dd091
Compare
depends-on: sonic-net/sonic-buildimage#18817
What I did
This change implements swss's ability to report it's readines to sysmonitor
Why I did it
The motivation is to report
PortInitDoneto sysmonitor and not just the startup of swssHow I verified it
sysmonitorDetails if related