Unused code in test_cacl_application.py

[svelamal]

Description

The tests cacl/test_cacl_application.py::test_cacl_application_dualtor[active_tor-m64-tor-0-None] and test_cacl_application_dualtor[standby_tor-m64-tor-1-None] fail on Cisco testbeds because the script is finding below iptables rules that are unexpected on both the DUTs.

"-A INPUT -p udp -m udp --dport 67 -j DHCP",
"-A DHCP -j RETURN",
"-N DHCP"

The script has a module fixture to ignore these rules for dualtor testbed at https://github.com/sonic-net/sonic-mgmt/blob/202205/tests/cacl/test_cacl_application.py#L23 but the variable ignored_iptable_rules is not being used anywhere in the script. Ideally, it should be added to the ignored list in https://github.com/sonic-net/sonic-mgmt/blob/202205/tests/cacl/test_cacl_application.py#L757.

Steps to reproduce the issue

Running cacl/test_cacl_application.py:: test_cacl_application_dualtor on dualtor testbed with 202205 image

Describe the results you received

Describe the results you expected

Additional information you deem important (e.g. issue happens only occasionally)

Output of show version

cisco@m64-tor-0:~$ show ver

SONiC Software Version: SONiC.azure_cisco_202205.3995-dirty-20230328.041108
Distribution: Debian 11.6
Kernel: 5.10.0-18-2-amd64
Build commit: 57a46d6a4
Build date: Tue Mar 28 13:55:09 UTC 2023
Built by: sonicci@sonic-ci-17-lnx

Platform: x86_64-8102_64h_o-r0
HwSKU: Cisco-8102-C64
ASIC: cisco-8000
ASIC Count: 1
Serial Number: FLM26390DYE
Model Number: 8102-64H-O
Hardware Revision: 1.0
Uptime: 06:21:56 up  5:41,  1 user,  load average: 0.52, 0.47, 0.53
Date: Tue 18 Apr 2023 06:21:56

[Aravind-Subbaroyan]

@kevinwangsk - could you please review this?