Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[202205][Auto-Techsupport] Fix the coredump_gen_handler Exception when the History table is empty (#2265) #2433

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

stepanblyschak
Copy link
Contributor

@stepanblyschak stepanblyschak commented Oct 10, 2022

What I did

BACKPORT OF: #2265

coredump_gen_handler script is throwing exception currently when the history table is empty.

root@r-lionfish-14:/home/admin# cat /tmp/coredump_gen_handler.log
Traceback (most recent call last):
  File "/usr/local/bin/coredump_gen_handler.py", line 82, in <module>
    main()
  File "/usr/local/bin/coredump_gen_handler.py", line 77, in main
    cls.handle_core_dump_creation_event()
  File "/usr/local/bin/coredump_gen_handler.py", line 60, in handle_core_dump_creation_event
    invoke_ts_command_rate_limited(self.db, EVENT_TYPE_CORE, {CORE_DUMP: self.core_name}, self.container)
  File "/usr/local/lib/python3.9/dist-packages/utilities_common/auto_techsupport_helper.py", line 331, in invoke_ts_command_rate_limited
    cooloff_passed = verify_rate_limit_intervals(db, global_cooloff, container_cooloff, container)
  File "/usr/local/lib/python3.9/dist-packages/utilities_common/auto_techsupport_helper.py", line 291, in verify_rate_limit_intervals
    if container_cooloff and container in ts_map:
TypeError: argument of type 'NoneType' is not iterable

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

…n the History table is empty (sonic-net#2265)

coredump_gen_handler script is throwing exception currently when the history table is empty.
Fix this issue and add a UT

Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
@liat-grozovik liat-grozovik changed the title [202205][Auto-Techsupport] Fix the coredump_gen_handler Exception whe… [202205][Auto-Techsupport] Fix the coredump_gen_handler Exception when the History table is empty (#2265) Oct 11, 2022
@liat-grozovik liat-grozovik merged commit e111ad4 into sonic-net:202205 Oct 11, 2022
dgsudharsan added a commit to dgsudharsan/sonic-buildimage that referenced this pull request Oct 18, 2022
Update sonic-utilities submodule pointer to include the following:
* ab21b58 [202205] check for vxlan mapping before removing vlan (sonic-net#2388) ([sonic-net#2446](sonic-net/sonic-utilities#2446))
* e111ad4 [202205][Auto-Techsupport] Fix the coredump_gen_handler Exception when the History table is empty (sonic-net#2265) ([sonic-net#2433](sonic-net/sonic-utilities#2433))
* 6925947 [watermarkstat][202205] Add new warning message for the 'q_shared_multi' counters ([sonic-net#2406](sonic-net/sonic-utilities#2406))

Signed-off-by: dgsudharsan <sudharsand@nvidia.com>
liat-grozovik pushed a commit to sonic-net/sonic-buildimage that referenced this pull request Oct 23, 2022
Update sonic-utilities submodule pointer to include the following:
* ab21b58 [202205] check for vxlan mapping before removing vlan (#2388) ([#2446](sonic-net/sonic-utilities#2446))
* e111ad4 [202205][Auto-Techsupport] Fix the coredump_gen_handler Exception when the History table is empty (#2265) ([#2433](sonic-net/sonic-utilities#2433))
* 6925947 [watermarkstat][202205] Add new warning message for the 'q_shared_multi' counters ([#2406](sonic-net/sonic-utilities#2406))

Signed-off-by: dgsudharsan <sudharsand@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants