Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[db_migrator] Add missing attribute 'weight' to route entries in APPL DB #2691

Merged
merged 5 commits into from
Mar 3, 2023
Merged

[db_migrator] Add missing attribute 'weight' to route entries in APPL DB #2691

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4a065b4
[db_migrator] Add missing attribute 'weight' to route entries in APPL DB
vaibhavhd Feb 23, 2023
e825097
Add unit test to cover migration of routes w/o weight attribute
vaibhavhd Feb 27, 2023
138975d
[UT] Remove unnecessary fields from DB input
vaibhavhd Feb 27, 2023
0089c2a
Move migration logic to dedicated method
vaibhavhd Mar 2, 2023
f0c5422
Name change for generic handling of route table migration
vaibhavhd Mar 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions scripts/db_migrator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -899,6 +899,17 @@ def common_migration_ops(self):
else:
log.log_notice("Asic Type: {}, Hwsku: {}".format(self.asic_type, self.hwsku))

route_table = self.appDB.get_table("ROUTE_TABLE")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you move this to a dedicated function.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, moved this logic to a method now.

for route_prefix, route_attr in route_table.items():
if 'weight' not in route_attr:
if type(route_prefix) == tuple:
# IPv6 route_prefix is returned from db as tuple
route_key = "ROUTE_TABLE:" + ":".join(route_prefix)
else:
# IPv4 route_prefix is returned from db as str
route_key = "ROUTE_TABLE:{}".format(route_prefix)
self.appDB.set(self.appDB.APPL_DB, route_key, 'weight','')
yxieca marked this conversation as resolved.
Show resolved Hide resolved

def migrate(self):
version = self.get_version()
log.log_info('Upgrading from version ' + version)
Expand Down