-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make PFC commands use a class #3057
Merged
Merged
Commits on May 28, 2024
-
Make pfc commands use a class.
This change puts contents originally in pfc/main.py into a class, to support the usage of the multi-asic helper in a future change. This change is required, as multi-asic helper relies on certain members of the class to exist. The multi-asic class helper will be used to add multi-asic support to pfc commands.
Configuration menu - View commit details
-
Copy full SHA for 4e11595 - Browse repository at this point
Copy the full SHA 4e11595View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0aacc29 - Browse repository at this point
Copy the full SHA 0aacc29View commit details -
Configuration menu - View commit details
-
Copy full SHA for 666ca91 - Browse repository at this point
Copy the full SHA 666ca91View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29c1681 - Browse repository at this point
Copy the full SHA 29c1681View commit details -
Configuration menu - View commit details
-
Copy full SHA for 15c1bae - Browse repository at this point
Copy the full SHA 15c1baeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e96eea - Browse repository at this point
Copy the full SHA 5e96eeaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e7731f - Browse repository at this point
Copy the full SHA 4e7731fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ff4f399 - Browse repository at this point
Copy the full SHA ff4f399View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8566ef7 - Browse repository at this point
Copy the full SHA 8566ef7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 735bccd - Browse repository at this point
Copy the full SHA 735bccdView commit details
Commits on May 29, 2024
-
Removed UTILITIES_UNIT_TESTING
Removed the use of the environment variable to test `config asymmetric on`. Instead replaced the validation method with a direct check for the expected CONFIG_DB entry. Also removed the unnecessary classmethods in TestPfcBase.
Configuration menu - View commit details
-
Copy full SHA for cc424b4 - Browse repository at this point
Copy the full SHA cc424b4View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.