Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multi-asic behaviour for watermarkstat #3060

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix multi-asic behaviour for watermarkstat #3060

wants to merge 3 commits into from

Commits on Mar 25, 2024

  1. Adds multi-asic support to watermarkstat, fixing watermark/persistent… 

    …-watermark related commands.

Previously, the following commands were not behaving correctly on multi-asic devices,
as the '-n' namespace option was not available, and correct namespaces were not traversed
on multi-asic devices.

* show buffer_pool watermark/persistent-watermark
* show headroom-pool watermark/persistent-watermark
* show priority-group persistent-watermark/watermark
* show queue persistent-watermark/watermark

This change fixes multi-asic behaviour of CLI commands that rely on watermarkstat,
as listed above.
    @bktsim-arista @arista-nwolfe
    bktsim-arista authored and arista-nwolfe committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    6e8703a View commit details
    Browse the repository at this point in the history

  2. add test for invalid namespace

    @bktsim-arista @arista-nwolfe
    bktsim-arista authored and arista-nwolfe committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    4cca9a3 View commit details
    Browse the repository at this point in the history

  3. watermarkstat logic

    @bktsim-arista @arista-nwolfe
    bktsim-arista authored and arista-nwolfe committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    8221148 View commit details
    Browse the repository at this point in the history