Support for aggregrate VOQ Counters. #3163
Open
+80
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivekverma-arista
changed the title
There was a problem hiding this comment.
- Based on my understanding,
- Sysport is the one where VoQ pointing to and we are aggregating the stats for ?
- fap id is the source asics where we are getting the count and aggregating for all faps ?
- idx is the VoQ id 0-7 ? or real VoQ id ?
- Do we support "show queue counter --voq" without any interface info ?
- Can you please add test case for this ?
vmittal-msft
approved these changes
May 24, 2024
|
|
||
| from collections import namedtuple, OrderedDict | ||
| from natsort import natsorted | ||
| from tabulate import tabulate | ||
| from sonic_py_common import multi_asic | ||
| from sonic_py_common import multi_asic, device_info | ||
| from swsscommon import swsscommon |
There was a problem hiding this comment.
Where are you using swsscommon?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added CLI support for aggregate VOQ counters according to HLD #1578
How I did it
Extended the existing CLI command
show queue counters [interface] --voqfor the SSI.How to verify it
Sent traffic destined to egress out of different queues of a interface through multiple ingress interface chosen across FSIs and verified that the command displays the correct aggregate view of the counters when run from the SSI
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)