Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asym PFC configuration fix #632

Merged
merged 1 commit into from
Sep 17, 2019
Merged

Conversation

nazariig
Copy link
Collaborator

@nazariig nazariig commented Sep 6, 2019

Signed-off-by: Nazarii Hnydyn nazariig@mellanox.com

- What I did

  • Fixed Asym PFC configuration

- How I did it

  • Added missing argument

- How to verify it

  1. root@sonic:/home/admin# config interface pfc asymmetric Ethernet0 off
  2. root@sonic:/home/admin# config interface pfc asymmetric Ethernet0 on

- Previous command output (if the output of a command-line utility has changed)

root@sonic:/home/admin# config interface Ethernet0 pfc asymmetric off
Usage: config interface [OPTIONS] COMMAND [ARGS]...

Error: No such command "Ethernet0".

root@sonic:/home/admin# config interface pfc asymmetric Ethernet0 off
Usage: config interface pfc asymmetric [OPTIONS] STATUS

Error: Invalid value for "status": invalid choice: Ethernet0. (choose from on, off)

root@sonic:/home/admin# config interface pfc asymmetric off Ethernet0
Usage: config interface pfc asymmetric [OPTIONS] STATUS

Error: Got unexpected extra argument (Ethernet0)

- New command output (if the output of a command-line utility has changed)

root@sonic:/home/admin# config interface pfc asymmetric Ethernet0 off

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
@nazariig
Copy link
Collaborator Author

nazariig commented Sep 9, 2019

@jleveque please have a look.

@nazariig
Copy link
Collaborator Author

@lguohan please have a look.

@lguohan lguohan merged commit c1c53f5 into sonic-net:master Sep 17, 2019
yxieca pushed a commit that referenced this pull request Sep 17, 2019
Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
yxieca added a commit that referenced this pull request Sep 18, 2019
yxieca added a commit to yxieca/sonic-utilities that referenced this pull request Sep 18, 2019
yxieca added a commit that referenced this pull request Sep 18, 2019
yxieca added a commit that referenced this pull request Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants