Added 'config core' and 'show cores' CLI commands

config/main.py

@@ -336,6 +336,7 @@ def _reset_failed_services():
         'bgp',
         'dhcp_relay',
         'hostcfgd',
+        'coredump-config',
         'hostname-config',
         'interfaces-config',
         'lldp',
@@ -359,6 +360,7 @@ def _reset_failed_services():
 
 def _restart_services():
     services_to_restart = [
+        'coredump-config',
         'hostname-config',
         'interfaces-config',
         'ntp-config',
@@ -1503,3 +1505,35 @@ def del_ntp_server(ctx, ntp_ip_address):
 
 if __name__ == '__main__':
     config()
+
+#
+# 'core' group ('config core ...')
+#
+@config.group()
+def core():
+    """ Configure coredump """
+    if os.geteuid() != 0:
+        exit("Root privileges are required for this operation")
+    pass
+
+@core.command()
+@click.argument('disable', required=False)
+def disable(disable):
+    """Administratively Disable coredump generation"""
+    config_db = ConfigDBConnector()
+    config_db.connect()
+    table = "COREDUMP"
+    key = "config"
+    config_db.set_entry(table, key, {"enabled": "false"})
+    run_command("systemctl restart coredump-config")
+
+@core.command()
+@click.argument('enable', required=False)
+def enable(enable):
+    """Administratively Enable coredump generation"""
+    config_db = ConfigDBConnector()
+    config_db.connect()
+    table = "COREDUMP"
+    key = "config"
+    config_db.set_entry(table, key, {"enabled": "true"})
+    run_command("systemctl restart coredump-config")

scripts/generate_dump

@@ -417,7 +417,7 @@ main() {
             continue
         fi
         # don't gzip already-gzipped log files :)
-        if [ -z "${file##*.gz}" ]; then
+        if [ -z "${file##*.gz}" ] || [ -z "${file##*.lz4}" ]; then
             save_file $file log false
         else
             save_file $file log true

show/main.py

@@ -1602,6 +1602,64 @@ def system_memory(verbose):
     cmd = "free -m"
     run_command(cmd, display_cmd=verbose)
 
+#
+# 'coredumpctl' group ("show cores")
+#
+
+@cli.group(cls=AliasedGroup, default_if_no_args=False)
+def cores():
+    """Show core dump events encountered"""
+    pass
+
+# 'config' subcommand ("show cores config")
+@cores.command()
+@click.option('--verbose', is_flag=True, help="Enable verbose output")
+def config(verbose):
+    """ Show coredump configuration """
+    # Default admin mode
+    admin_mode = True
+    # Obtain config from Config DB
+    config_db = ConfigDBConnector()
+    if config_db is not None:
+        config_db.connect()
+        table_data = config_db.get_table('COREDUMP')
+        if table_data is not None:
+            config_data = table_data.get('config')
+            if config_data is not None:
+                admin_mode = config_data.get('enabled')
+                if admin_mode is not None and admin_mode.lower() == 'false':
+                    admin_mode = False
+
+    # Core dump administrative mode
+    if admin_mode:
+        print('Coredump : %s' % 'Enabled')
+    else:
+        print('Coredump : %s' % 'Disabled')
+
+# 'list' subcommand ("show cores list")
+@cores.command()
+@click.argument('pattern', required=False)
+@click.option('--verbose', is_flag=True, help="Enable verbose output")
+def list(verbose, pattern):
+    """ List available coredumps """
+
+    cmd = "coredumpctl list"
+    if pattern is not None:
+        cmd = cmd + " " + pattern
+    run_command(cmd, display_cmd=verbose)
+
+# 'info' subcommand ("show cores info")
+@cores.command()
+@click.argument('pattern', required=False)
+@click.option('--verbose', is_flag=True, help="Enable verbose output")
+def info(verbose, pattern):
+    """ Show information about one or more coredumps """
+
+    cmd = "coredumpctl info"
+    if pattern is not None:
+        cmd = cmd + " " + pattern
+    run_command(cmd, display_cmd=verbose)
+
 @cli.group(cls=AliasedGroup, default_if_no_args=False)
 def vlan():
     """Show VLAN information"""