Enhancements to allow custom umask usage while executing plugins #42
+44
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use default umask value of 022 to execute ztp plugins
- User can provide a custom umask octal value string as part of plugin data
if a specific umask is required.
{
"plugin" : {
"url" : "http://10.1.1.1/plugins/my-plugin",
"umask" : "177"
}
}
- Firmware plugin has been modified to always use 022 umask when installing
sonic image
- Added unit test cases to test user specified umask value
|
@dgsudharsan, can you please help review this PR |
|
@qiluo-msft, @isabelmsft for viz... |
|
@adyeung can you please find someone from BRCM to review this PR? |
adyeung
approved these changes
Feb 13, 2024
dgsudharsan
approved these changes
Feb 13, 2024
qiluo-msft
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use default umask value of 022 to execute ztp plugins
User can provide a custom umask octal value string as part of plugin data if a specific umask is required. { "plugin" : { "url" : "http://10.1.1.1/plugins/my-plugin", "umask" : "177" } }
Firmware plugin has been modified to always use 022 umask when installing sonic image
Added unit test cases to test user specified umask value