Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tips for some table cells #274

Merged
merged 32 commits into from
May 11, 2024
Merged

Tips for some table cells #274

merged 32 commits into from
May 11, 2024

Conversation

ru-danko
Copy link
Collaborator

@ru-danko ru-danko commented May 9, 2024

No description provided.

@coveralls
Copy link

coveralls commented May 9, 2024

Pull Request Test Coverage Report for Build 9042356549

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 56 (0.0%) changed or added relevant lines in 7 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 4.934%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/Tips/index.ts 0 1 0.0%
src/utils/getCaseTips/index.ts 0 1 0.0%
src/components/Modals/DetailModal/DetailModal.tsx 0 2 0.0%
src/components/Tips/Tips.tsx 0 5 0.0%
src/components/Pages/Grammar/Grammar.tsx 0 6 0.0%
src/components/Table/Table.tsx 0 10 0.0%
src/utils/getCaseTips/getCaseTips.ts 0 31 0.0%
Files with Coverage Reduction New Missed Lines %
src/components/Table/Table.tsx 1 0.0%
src/components/Pages/Grammar/Grammar.tsx 1 0.0%
Totals Coverage Status
Change from base Build 8215530980: -0.1%
Covered Lines: 129
Relevant Lines: 2993

💛 - Coveralls

case 'ins': caseTips = 'kym? čim?'; break;
case 'loc': caseTips = 'kom? čem?'; break;
case 'voc': caseTips = 'hej!'; break;
default: caseTips = `test_${caseItem}`;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dlja čego tutoj placeholder, test_${caseItem} jest potrěbny?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ja igraju se... Možeš poka ne gledeti, to jest draft. Mně bude potrěbna tvoja pomoč sdělati lokalny nodejs server, aby testovati svoje igrački ne tut.

({ str, tips, className }: ITipsProps) => {
const dispatch = useDispatch();
const onClick = () => {
dispatch(setNotificationAction({ text: tips }));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ne je li to prěmnogo tolsto – pokazyvati "toast notification"?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Myslim, da najlěpše bude pokazati někako kolo s "i" (ℹ️ ), kde pri natiskanju abo navodženju kursora bude někaky "popover"... 🗯️

Copy link
Collaborator

@noomorph noomorph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The accessibility has a lot of space for improvement, but otherwise this is fine enough and seems to fulfill the goal. Thank you for the work!

@ru-danko ru-danko merged commit 798bd53 into master May 11, 2024
5 checks passed
@ru-danko ru-danko deleted the feat/cases-tips branch May 11, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants