-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tips for some table cells #274
Conversation
Pull Request Test Coverage Report for Build 9042356549Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
case 'ins': caseTips = 'kym? čim?'; break; | ||
case 'loc': caseTips = 'kom? čem?'; break; | ||
case 'voc': caseTips = 'hej!'; break; | ||
default: caseTips = `test_${caseItem}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dlja čego tutoj placeholder, test_${caseItem}
jest potrěbny?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ja igraju se... Možeš poka ne gledeti, to jest draft. Mně bude potrěbna tvoja pomoč sdělati lokalny nodejs server, aby testovati svoje igrački ne tut.
src/components/Tips/Tips.tsx
Outdated
({ str, tips, className }: ITipsProps) => { | ||
const dispatch = useDispatch(); | ||
const onClick = () => { | ||
dispatch(setNotificationAction({ text: tips })); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ne je li to prěmnogo tolsto – pokazyvati "toast notification"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Myslim, da najlěpše bude pokazati někako kolo s "i" (ℹ️ ), kde pri natiskanju abo navodženju kursora bude někaky "popover"... 🗯️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The accessibility has a lot of space for improvement, but otherwise this is fine enough and seems to fulfill the goal. Thank you for the work!
No description provided.