Skip to content

Commit

Permalink
Faster performance test if None timeouts
Browse files Browse the repository at this point in the history
  • Loading branch information
sonic182 committed Oct 27, 2019
1 parent 71d742b commit 9ad5e76
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 5 deletions.
8 changes: 6 additions & 2 deletions aiosonic/timeout.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@

from typing import Optional


class Timeouts():
"""Timeouts class wrapper."""

def __init__(self, sock_connect: float = 5, sock_read: float = 30,
pool_acquire: float = None, request_timeout: float = 60):
def __init__(self, sock_connect: Optional[float] = 5,
sock_read: Optional[float] = 30,
pool_acquire: Optional[float] = None,
request_timeout: Optional[float] = 60):
"""Timeouts.
Arguments:
Expand Down
9 changes: 6 additions & 3 deletions tests/performance.py
Original file line number Diff line number Diff line change
Expand Up @@ -79,11 +79,11 @@ async def performance_aiohttp(url, concurrency):
return await timeit_coro(session.get, (url))


async def performance_aiosonic(url, concurrency, pool_cls=None):
async def performance_aiosonic(url, concurrency, pool_cls=None, timeouts=None):
"""Test aiohttp performance."""
return await timeit_coro(
aiosonic.get, url, connector=TCPConnector(
pool_size=concurrency, pool_cls=pool_cls))
pool_size=concurrency, pool_cls=pool_cls), timeouts=timeouts)


async def performance_httpx(url, concurrency, pool_cls=None):
Expand Down Expand Up @@ -127,7 +127,10 @@ def do_tests(url):
res1 = loop.run_until_complete(performance_aiohttp(url, concurrency))

# aiosonic
res2 = loop.run_until_complete(performance_aiosonic(url, concurrency))
# faster if not timeouts (asyncio.wait_for makes loop slower)
timeouts = aiosonic.timeout.Timeouts(None, None, None, None)
res2 = loop.run_until_complete(performance_aiosonic(
url, concurrency, timeouts=timeouts))

# requests
res3 = timeit_requests(url, concurrency)
Expand Down

0 comments on commit 9ad5e76

Please sign in to comment.