Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass External Programs to Custom Command #732

Merged
merged 14 commits into from
Feb 2, 2023
Merged

Pass External Programs to Custom Command #732

merged 14 commits into from
Feb 2, 2023

Commits on Feb 2, 2023

  1. Custom command: Initial logic for passing gamescope etc to only custo… 

    …m commands
    @sonic2kk
    sonic2kk committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    9c829da View commit details
    Browse the repository at this point in the history

  2. Custom command: Pass FINALOUTCMD array to extProtonRun 

    Still won't properly pass commands as it does not append the values in FINALOUTCMD yet.
Also probably won't work for native custom commands.
    @sonic2kk
    sonic2kk committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    15f5d17 View commit details
    Browse the repository at this point in the history

  3. Custom command: Pass GameScope, GameMode and MangoHUD when ONLY_CUSTO… 

    …MCMD

When we enable ONLY_CUSTOMCMD, now GameScope, GameMode and MangoHUD will be enabled.
Still need to verify that we do not incorrectly do this on Steam Deck, just to be safe.
Also still does not apply to native games.
Finally, GameScope does not seem to pass its arguments yet, just the path to GameScope e.g. /usr/bin/gamescope
    @sonic2kk
    sonic2kk committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    e26cbee View commit details
    Browse the repository at this point in the history

  4. Custom command: Pass GameScope arguments to ONLY_CUSTOMCMD 

    Still does not apply to native games, but good initial progress for now.
    @sonic2kk
    sonic2kk committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    515a8e5 View commit details
    Browse the repository at this point in the history

  5. Command line: Show notifier for custom program launches 

    Other langfiles need updated.
Still does not apply to native game launches.
Probably not all external programs are passed but maybe all that we need to are passed (e.g., is boxtron really required/relevant?)
Finally, custom external program args like GameScope are not passed to Wine launches as extWineRun will need refactored for this.
    @sonic2kk
    sonic2kk committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    5552d90 View commit details
    Browse the repository at this point in the history

  6. Custom command: Initial work for native game external program passing 

    For now it seems like only GameMode is being parsed and passed correctly to native games, but it's a start.
    @sonic2kk
    sonic2kk committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    c73fce5 View commit details
    Browse the repository at this point in the history

  7. Custom command: Pass GameScope for native games

    @sonic2kk
    sonic2kk committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    020164a View commit details
    Browse the repository at this point in the history

  8. Custom command: Show notifier for native games

    @sonic2kk
    sonic2kk committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    f8f074c View commit details
    Browse the repository at this point in the history

  9. Custom command: Add explicit toggle for passing external programs

    @sonic2kk
    sonic2kk committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    583e1fc View commit details
    Browse the repository at this point in the history

  10. Custom command: Add toggle for passing programs to custom command

    @sonic2kk
    sonic2kk committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    174a671 View commit details
    Browse the repository at this point in the history

  11. Custom command: update langfiles

    @sonic2kk
    sonic2kk committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    0189b8f View commit details
    Browse the repository at this point in the history

  12. Custom command: Use buildCustomCmdLaunch in launchSteamGame 

    The code for buildCustomCmdLaunch was taken from the first several lines of launchSteamGame, with the launch command array being the only real change.
It should be possible to re-use this function instead of having duplicated code.
    @sonic2kk
    sonic2kk committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    d898c79 View commit details
    Browse the repository at this point in the history

  13. Custom command: remove commented code

    @sonic2kk
    sonic2kk committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    738ca31 View commit details
    Browse the repository at this point in the history

  14. Custom command: bump version

    @sonic2kk
    sonic2kk committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    72d388a View commit details
    Browse the repository at this point in the history