Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Menu: Add toggle for Steam Deck compatibility information #782

Merged
merged 3 commits into from Apr 12, 2023

Conversation

sonic2kk
Copy link
Owner

@sonic2kk sonic2kk commented Apr 11, 2023

May help #781.

Adds a checkbox to the global menu which controls whether or not to fetch Steam Deck compatibility information. This seems to be an outlier, as other options (ProtonDB rating, game info, etc) already have toggles here. Guess it slipped my mind when implementing it (#634, 6c64dc2).

Needs some further testing, and other options may also need options. Should investigate that too.

Also, I don't think this feature has a wiki page. Should add one.

@sonic2kk sonic2kk marked this pull request as ready for review April 11, 2023 23:55
@sonic2kk
Copy link
Owner Author

@sonic2kk
Copy link
Owner Author

Made a change in this PR too which doesn't display the Steam Deck compatibility rating on the wait requester if we don't have it. The Main Menu already followed this too, so it's a little bit of consistency.

Also improved some of the logging too following the toggle added here. If we have DLSTEAMDECKCOMPATINFO off, it won't warn about jq potentially being missing when we don't have any Steam Deck compat info. We would expect to not have any compat info if this option is off.

@sonic2kk sonic2kk merged commit d5c23f8 into master Apr 12, 2023
@sonic2kk sonic2kk deleted the network-toggles branch April 13, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant