Vortex: Remove dotnet48 installation; use Winetricks for dotnetdesktop6 #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vortex 1.8.0 and above no longer require dotnet48 to install, however Vortex still requires .NET 6 or above. The manual .NET 6 installation works, but Winetricks should be able to install .NET 6 for us, so we should replace the manual code.
sonic2kk
changed the title
Vortex still requires dotnet6, but we can install this during installation with Winetricks using the dotnetdesktop6 Winetrick.
|
This appears to work for Vortex 1.8.1 and Vortex 1.8.2 Pre-Release, so this should be good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vortex 1.8.0 and above no longer require dotnet48 to install, however Vortex still requires .NET 6 or above. The manual .NET 6 installation works, but Winetricks should be able to install .NET 6 for us, so we should replace the manual code. This was not the case when this logic was written, as Winetricks could not install dotnet6 at that time.
The relevant Winetrick we want is
dotnetdesktop6. I am not sure if this is available in the latest stable Winetricks, but as all users should know, an up-to-date Winetricks should always be used when tinkering. A note will be added to the Vortex wiki around this.Currently Vortex will work with this PR, but it'll tell you that you need .NET 6 or above. It does offer a fix, and the fix will correctly install .NET 6, but I would still rather automate this step as it should be relatively cheap. Also, the .NET 6 install logic was in the
startVortexsection. I guess this was because it was needed after Vortex was installed and set up, but now it can probably go in theinstallVortexsection.This should also significantly reduce the footprint that Vortex has, down from about 3.5gb to 1.2gb on my PC. Installation also seems to be around a minute or so faster (dotnetdesktop6 installs very quickly compared to dotnet48).