GameScope: Add support for selecting ReShade Effects #918
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer GameScope releases have support for selecting a ReShade effect file to load and display over the game. This doesn't actually use ReShade, GameScope now just has a way of compiling ReShade shaders and using it on the compositor itself, rather than the game.
This PR adds two new options to our GameScope GUI which expose these options. This is under the "Filtering" options as I felt it was nnecessary to create a new category for these options. If ReShade support in GameScope matures enough to have several options which warrant a standalone heading, we'll add it in future.
This support in GameScope upstream is still in its infancy, but this is a good starting point for us downstream and better than having no option.
The
--reshade-technique-idx
is something I don't really understand, but from looking at the code, it appears that it will reject blank values or0
values, so we do that here. It also appears that since it usesstd::atoi
, that it expects an integer value, hence why I went with a spinner for this option.TODO: