Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GameScope: Add support for selecting ReShade Effects #918

Merged
merged 3 commits into from Sep 24, 2023

Conversation

sonic2kk
Copy link
Owner

@sonic2kk sonic2kk commented Sep 24, 2023

Newer GameScope releases have support for selecting a ReShade effect file to load and display over the game. This doesn't actually use ReShade, GameScope now just has a way of compiling ReShade shaders and using it on the compositor itself, rather than the game.

This PR adds two new options to our GameScope GUI which expose these options. This is under the "Filtering" options as I felt it was nnecessary to create a new category for these options. If ReShade support in GameScope matures enough to have several options which warrant a standalone heading, we'll add it in future.

image

This support in GameScope upstream is still in its infancy, but this is a good starting point for us downstream and better than having no option.

The --reshade-technique-idx is something I don't really understand, but from looking at the code, it appears that it will reject blank values or 0 values, so we do that here. It also appears that since it uses std::atoi, that it expects an integer value, hence why I went with a spinner for this option.


TODO:

@sonic2kk
Copy link
Owner Author

Menu order seems to still work fine.

@sonic2kk
Copy link
Owner Author

Adding the other shader repo will come another time in a different push/PR. For now, this feature is ready!

@sonic2kk sonic2kk merged commit 5b0c715 into master Sep 24, 2023
@sonic2kk sonic2kk deleted the gamescope-reshade branch September 30, 2023 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant