x64dbg: Fix GitHub Snapshot download #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonic2kk
force-pushed
the
x64dbg-dl-fix
branch
from
52275dc
to
88586d6
Compare
|
Was confirmed to work by OP in #947, so it should be ready to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #947.
This is the last part of the x64dbg issue, and fixes the download not working since GitHub changed how it loads assets on the release page.
Now we hardcode the path to the
expanded_assetsand grep on the first link. We always want snapshot, and this tag hasn't changed in 8 years, so it's not likely to anytime soon. We can always point to this tag's expanded assets since we always want the snapshot.Tested and this fixes the issue for me, x64dbg can now download and extract successfully!