Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue ImageLoader requests #28

Closed
sonicmax opened this issue Jul 28, 2016 · 3 comments
Closed

Queue ImageLoader requests #28

sonicmax opened this issue Jul 28, 2016 · 3 comments

Comments

@sonicmax
Copy link
Owner

Currently it attempts to load them all at once and updates UI whenever the request finishes - would be better to load them in order.

@sonicmax
Copy link
Owner Author

sonicmax commented Jul 28, 2016

e059a44

This solves the problem on a per message basis, but still leads to weird behaviour where images from one message will load before images from a previous message. Best way to handle this would probably be to create an ImageQueue class which iterates over each message in order

@sonicmax
Copy link
Owner Author

2c9a47b

Now need to figure out how to remove ImageLoaders from queue if message is no longer displayed on screen (to prioritise visible messages when user scrolls).

@sonicmax sonicmax changed the title Queue image load requests and execute in order Queue ImageLoader requests Jul 28, 2016
@sonicmax sonicmax removed the ui label Jul 28, 2016
@sonicmax
Copy link
Owner Author

ImageLoaders are aborted/removed from queue once containing view has been detached from window - 8759454

Need to find out what happens after activity is destroyed (ie do ImageLoaders continue to execute?) but I can open a new issue for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant