Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve name handling #14

Merged
merged 2 commits into from
Aug 27, 2021
Merged

Conversation

ticky
Copy link
Contributor

@ticky ticky commented Aug 17, 2021

This updates the name handling in two ways;

  1. It updates the maximum length to 39 as discussed in Maximum name length seems to be one character too long #13; I've tested this repeatedly and it's consistently the true limit
  2. Names are no longer transformed to uppercase, as GDMenu can handle mixed case titles just fine

Fixes #13

@sonik-br
Copy link
Owner

Thanks for the PR!
I can't test it right now as I don't have access to my dreamcast at the moment.
I do remember some users asking me to force the upercase but can't remember why. I think it was hard to read on a crt tv but might be wrong. Can you test it?

@ticky
Copy link
Contributor Author

ticky commented Aug 18, 2021

I don't have a CRT to test with, but it seems strange to me to restrict this for a subset of users when they could just use the caps lock key 😜

I'd suggest a compromise of making this a user-configurable setting, but I don't have enough experience with .NET core stuff to get far in that myself, I'm afraid

@sonik-br
Copy link
Owner

I will merge the PR later today.
Your changes are working perfectly. Also the texts are very readable in a CRT TV.
Was testing it now and found another bug. Renaming the game in the list is not working (at least in the windows build).

@sonik-br sonik-br merged commit b1c5de4 into sonik-br:master Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maximum name length seems to be one character too long
2 participants