GUI-122 benchmark and propertyList component #93
Conversation
| @@ -0,0 +1,27 @@ | |||
| @import 'guide.less'; | |||
|
|
|||
| @property-list-label-fontColor: @color-light-font; | |||
There was a problem hiding this comment.
property-list-label-fontColor
посоны чо за ад с неймингами. не то не се.
| nextProps.keys.indexOf(key) !== -1, | ||
| ) | ||
| .map(key => { | ||
| config.push({ |
There was a problem hiding this comment.
const config: IPropertyListItem[] = Object.keys(Benchmark.defaultKeys)
.filter(
.filter(
.map(
| @@ -0,0 +1,27 @@ | |||
| @import 'guide.less'; | |||
|
|
|||
| @property-list-label-fontColor: @color-light-font; | |||
| </div> | ||
| <Benchmark | ||
| data={record.benchmarkMap} | ||
| keys={['cpuCount', 'ethHashrate', 'ramSize']} |
There was a problem hiding this comment.
it is bad practice /
whats wrong here? i will not explain this error one more time.
| @@ -135,6 +135,7 @@ export interface IAccountBrief { | |||
| } | |||
|
|
|||
| export interface IBenchmarkMap { | |||
| [index: string]: string | number; | |||
There was a problem hiding this comment.
previous version looks better.
what difference with IDictionary now ?
There was a problem hiding this comment.
this type definition is nonsensical in this form
| @@ -0,0 +1,83 @@ | |||
| import * as React from 'react'; | |||
| import { IBenchmarkMap, IDictionary } from 'app/api/types'; | |||
There was a problem hiding this comment.
you should define this types here if it is possible.
there are no any reason to place IDictionary typedef there.
this definition is not related to api anyway
| gpuRamSize: 'GPU Ram size', | ||
| zcashHashrate: 'ZCahs hashrate', | ||
| redshiftGpu: 'Redshift', | ||
| } as IDictionary; |
There was a problem hiding this comment.
there are no needs to cast type.
also this type should be
public static readonly defaultKeys: { [P in key of IBenchmarkMap]: string } = { ...
No description provided.