Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sonmcli version command doesn't shows git commit hash #1537

Closed
nikonov1101 opened this issue Sep 20, 2018 · 1 comment
Closed

sonmcli version command doesn't shows git commit hash #1537

nikonov1101 opened this issue Sep 20, 2018 · 1 comment
Assignees
@nikonov1101
Labels
P: medium This PR/Issue has normal priority S: CLI This PR/Issue changes CLI 💩 T: bug This PR/Issue fixes a bug
Milestone
v0.4.12

Comments

@nikonov1101
Copy link
Member 

root@ʕ◔ϖ◔ʔ:~# sonmcli version
sonmcli  (linux/amd64/go1.10.2)
@nikonov1101 nikonov1101 added 💩 T: bug This PR/Issue fixes a bug S: CLI This PR/Issue changes CLI P: medium This PR/Issue has normal priority labels Sep 20, 2018
@nikonov1101 nikonov1101 added this to the v0.4.12 milestone Sep 20, 2018
@nikonov1101 nikonov1101 self-assigned this Sep 20, 2018
@nikonov1101
Copy link
Member Author

@antmat @3Hren how should I fix this? Now two solutions are checked:

  1. make AppVersion var from cmd/cobra.go exportable, use it in CLI. LDFLAGS won't be changed (more code, more flexible).
  2. introduce extra LDFLAGS only for CLI (one line in Makefile, duplication -> less flexible).

nikonov1101 pushed a commit that referenced this issue Sep 28, 2018
fix: proper version var for cli
46d942b 
Closes #1537
@nikonov1101 nikonov1101 mentioned this issue Sep 28, 2018
Merged
3Hren pushed a commit that referenced this issue Oct 1, 2018
@3Hren
fix: proper version var for cli (#1560)
55d5c8b 
Closes #1537
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikonov1101 nikonov1101

Labels
P: medium This PR/Issue has normal priority S: CLI This PR/Issue changes CLI 💩 T: bug This PR/Issue fixes a bug
Projects
None yet
Milestone
v0.4.12
Development

No branches or pull requests
1 participant
@nikonov1101