Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problems with socket in Relay #1566

Closed
DPolygalov opened this issue Oct 1, 2018 · 0 comments · Fixed by #1580
Closed

Problems with socket in Relay #1566

DPolygalov opened this issue Oct 1, 2018 · 0 comments · Fixed by #1580
Assignees
@3Hren
Labels
S: Relay This PR/Issue changes Relay 💩 T: bug This PR/Issue fixes a bug

Comments

@DPolygalov
Copy link
Member

DEV-969
sonmrelay 13312 root *004u sock 0,8 0t0 4133324 protocol: TCPv6
sonmrelay 13312 root *005u sock 0,8 0t0 4134817 protocol: TCPv6
sonmrelay 13312 root *006u sock 0,8 0t0 4134827 protocol: TCPv6
@DPolygalov DPolygalov added 💩 T: bug This PR/Issue fixes a bug S: Relay This PR/Issue changes Relay labels Oct 1, 2018
3Hren added a commit that referenced this issue Oct 3, 2018
@3Hren
fix: socket leak in Relay
de9afae 
Several weeks ago a new bug was introduced in Relay server - half of the remote peer sockets were leaked forever. This was because of improper synchronization during rendezvous point, where both remote server and client are met. So when a client did its job we closed only a server socket, not the client one and vise-verse.
This patch fixes such behavior - everything should work fine from now, at least with dead socket collection.

Closes #1566.
@3Hren 3Hren mentioned this issue Oct 3, 2018
Merged
3Hren added a commit that referenced this issue Oct 3, 2018
@3Hren
fix: socket leak in Relay (#1580)
348154c 
Several weeks ago a new bug was introduced in Relay server - half of the remote peer sockets were leaked forever. This was because of improper synchronization during rendezvous point, where both remote server and client are met. So when a client did its job we closed only a server socket, not the client one and vise-verse.
This patch fixes such behavior - everything should work fine from now, at least with dead socket collection.

Closes #1566.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@3Hren 3Hren

Labels
S: Relay This PR/Issue changes Relay 💩 T: bug This PR/Issue fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: socket leak in Relay sonm-io/core
2 participants
@3Hren @DPolygalov