feat: SSH into containers through Node #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3Hren
requested review from
antmat,
zavgorodnii,
nikonov1101 and
a team
as code owners
3Hren
force-pushed
the
feat/npp-ssh
branch
2 times, most recently
from
d3a226e
to
e781b2d
Compare
3Hren
added
S: Node
3Hren
force-pushed
the
feat/npp-ssh
branch
2 times, most recently
from
f05dc57
to
b7b8db3
Compare
This allows to perform SSH'ing into containers by specifying only deal and task identifiers independing of whereever those containers are being run. This is done by proxying the traffic through local Node. The idea is to hijack to incoming TCP connection with further resolving the real endpoint of a Worker where a container is being run by deal ID using NPP with further traffic forwarding directly into it. The Worker may not be having a public IP address.
nikonov1101
approved these changes
Aug 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to perform SSH'ing into containers by specifying only deal
and task identifiers independing of whereever those containers are being
run.
This is done by proxying the traffic through local Node.
The idea is to hijack to incoming TCP connection with further resolving
the real endpoint of a Worker where a container is being run by deal ID
using NPP with further traffic forwarding directly into it. The Worker
may not be having a public IP address.