refactor: single shot ask plans #1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR changes ask-plan behaviour, now after the order is cancelled, or deal is closed ask plan is removed. This should work better with optimus bot, as it does continous optimization and also simplify code, allowing to make separate scheduling for forward deals
antmat
requested review from
3Hren,
zavgorodnii,
nikonov1101 and
a team
as code owners
nikonov1101
reviewed
Sep 24, 2018
| @@ -392,7 +405,7 @@ func (m *Salesman) restoreState() error { | |||
| if err := m.resources.Consume(plan); err != nil { | |||
| m.log.Warnf("dropping ask plan due to resource changes") | |||
| //Ignore error here, as resources that were not consumed can not be released. | |||
| m.RemoveAskPlan(plan.ID) | |||
| m.RemoveAskPlan(context.TODO(), plan.ID) | |||
nikonov1101
reviewed
Sep 26, 2018
| ask, ok := m.askPlans[planID] | ||
| if !ok { | ||
| return fmt.Errorf("no such plan %s", planID) | ||
| //TODO: rework with error map |
| } | ||
|
|
||
| if !plan.GetOrderID().IsZero() { |
There was a problem hiding this comment.
what happens if user will try to remove ask-plan when order is still placing?
There was a problem hiding this comment.
looks like it will just return error and user can make another try
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes ask-plan behaviour, now after the order is cancelled,
or deal is closed ask plan is removed. This should work better with
optimus bot, as it does continous optimization and also simplify code,
allowing to make separate scheduling for forward deals