feat: keep internal state for Connor #1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikonov1101
requested review from
3Hren,
antmat and
zavgorodnii
as code owners
antmat
requested changes
Sep 25, 2018
connor/engine.go
Outdated
| @@ -66,13 +67,25 @@ var ( | |||
| Name: "sonm_orders_replaced", | |||
| Help: "Number of orders that were re-created on marker because of price deviation", | |||
| }) | |||
|
|
|||
| restoredOrdersCounter = prometheus.NewCounter(prometheus.CounterOpts{ | |||
connor/state.go
Outdated
| s.mu.Lock() | ||
| defer s.mu.Unlock() | ||
|
|
||
| id := order.GetId().Unwrap().String() |
connor/state.go
Outdated
| return ok | ||
| } | ||
|
|
||
| func (s *state) hasDeal(id string) bool { |
There was a problem hiding this comment.
incostistent with hasOrder
connor/state.go
Outdated
| defer s.mu.Unlock() | ||
|
|
||
| s.activeOrders[ord.GetId().Unwrap().String()] = ord | ||
| s.log.Debug("adding active order", |
There was a problem hiding this comment.
either 'added' or move before lock
connor/state.go
Outdated
| s.mu.Lock() | ||
| defer s.mu.Unlock() | ||
|
|
||
| s.activeOrders[ord.GetId().Unwrap().String()] = ord |
There was a problem hiding this comment.
create string id before lock and use it here and in log
connor/state.go
Outdated
| s.mu.Lock() | ||
| defer s.mu.Unlock() | ||
|
|
||
| s.deals[deal.GetId().Unwrap().String()] = &dealQuality{ |
connor/state.go
Outdated
| s.mu.Lock() | ||
| defer s.mu.Unlock() | ||
|
|
||
| s.log.Debug("deleting deal", zap.String("deal_id", id), zap.Int("total", len(s.deals))) |
There was a problem hiding this comment.
'deleted' and move after delete call
connor/state.go
Outdated
| return | ||
| } | ||
|
|
||
| s.log.Info("dumpling state to the disk") |
There was a problem hiding this comment.
split in two methods, write can possibly block for a long time
connor/state.go
Outdated
| zap.Int("queued", len(s.queuedOrders))) | ||
| } | ||
|
|
||
| func (s *state) deleteCreatingOrder(ord *types.Corder) { |
| @@ -252,6 +276,7 @@ func (e *engine) getOrderByID(ctx context.Context, id string) (*sonm.Order, erro | |||
|
|
|||
| func (e *engine) processOrderResult(ctx context.Context) { | |||
| for order := range e.ordersResultsChan { | |||
There was a problem hiding this comment.
looks like this should not be async
added 2 commits
September 25, 2018 15:34
antmat
approved these changes
Sep 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.