-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: price prediction for suppliers #1594
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikonov1101
reviewed
Oct 4, 2018
insonmnia/npp/relay/server.go
Outdated
@@ -701,7 +701,7 @@ func (m *server) processHandshake(ctx context.Context, conn net.Conn, handshake | |||
defer deleter() | |||
|
|||
select { | |||
case <-timer.C: | |||
case <-timer.C: // TODO SHIT! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
57b3d62
to
f76f5ba
Compare
nikonov1101
reviewed
Oct 4, 2018
optimus/predictor_service.go
Outdated
Optimization: OptimizationConfig{ | ||
Model: optimizationMethodFactory{ | ||
OptimizationMethodFactory: &defaultOptimizationMethodFactory{}, | ||
//OptimizationMethodFactory: &GreedyLinearRegressionModelFactory{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💩
nikonov1101
previously approved these changes
Oct 4, 2018
Node service is now capable to obtain an approximate predicted price for devices configuration, i.e. implements price prediction for suppliers.
817d152
to
cd6c10d
Compare
antmat
approved these changes
Oct 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
P: HIGH
This PR/Issue has the high priority
S: Node
This PR/Issue changes Node
T: feature
This PR/Issue adds a new feature
V: minor
This PR/Issue required minor version to be bumped
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node service is now capable to obtain an approximate predicted price for devices configuration, i.e. implements price prediction for suppliers.
An example of
devices.json
: