fix: chunked deals fetching in Optimus #1642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3Hren
added
💩 T: bug
While we're having constantly increasing the number of deals it may appear, that fetching the entire data set of deals can overflow the allowed gRPC response size. This commit fixes that behavior by fetching deals chunked.
3Hren
force-pushed
the
fix/optimus/fetch-deals
branch
from
82f2e3e
to
b399443
Compare
3Hren
changed the title
antmat
approved these changes
Oct 16, 2018
| pullLimit = 1000 | ||
| ordersPreallocateSize = 1 << 13 | ||
| pullLimit = 1000 | ||
| preallocateSize = 1 << 13 |
There was a problem hiding this comment.
better make a note that it is 8 KiB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we're having constantly increasing the number of deals it may appear, that fetching the entire data set of deals can overflow the allowed gRPC response size.
This commit fixes that behavior by fetching deals chunked.