Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: getTransactionReceipt To field unmarshalling #1660

Merged
merged 1 commit into from Oct 19, 2018
Merged

fix: getTransactionReceipt To field unmarshalling #1660

merged 1 commit into from Oct 19, 2018

Conversation

sokel
Copy link
Member

@sokel sokel commented Oct 19, 2018

Fix behaviour for parsing To field according to web3 json rpc scpec

to: DATA, 20 Bytes - address of the receiver. null when it's a contract creation transaction.

This fix affect contract' creation transactions.

@sokel sokel requested a review from a team as a code owner October 19, 2018 11:19
@sokel sokel requested a review from a team October 19, 2018 11:19
@sokel sokel added 💩 T: bug This PR/Issue fixes a bug P: HIGH This PR/Issue has the high priority V: patch This PR/Issue requires patch version to be bumped S: Blockchain This PR/Issue changes Blockchain API B: AS labels Oct 19, 2018
@3Hren 3Hren merged commit 79e8355 into master Oct 19, 2018
@3Hren 3Hren deleted the fix/receipt-parsing branch October 19, 2018 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3Hren 3Hren 3Hren approved these changes

Assignees
No one assigned
Labels
P: HIGH This PR/Issue has the high priority S: Blockchain This PR/Issue changes Blockchain API 💩 T: bug This PR/Issue fixes a bug V: patch This PR/Issue requires patch version to be bumped
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sokel @3Hren