feat: worker geolocation #1692
Merged
feat: worker geolocation #1692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3Hren
added
S: Worker
3Hren
requested review from
antmat,
zavgorodnii,
nikonov1101 and
a team
as code owners
nikonov1101
requested changes
Nov 13, 2018
insonmnia/worker/server.go
Outdated
| @@ -307,6 +316,31 @@ func (m *Worker) setupMaster() error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (m *Worker) setupGeoIP() error { | |||
| if len(m.publicIPs) == 0 { | |||
| return fmt.Errorf("failed to detect at least one public IP address") | |||
There was a problem hiding this comment.
Probably, It will be better to try to detect IP address via some external service
3Hren
force-pushed
the
feat/worker/geoip
branch
from
1d687a5
to
b2386b5
Compare
Now Workers are capable to detect the country ISO code where they are located and provide it in status handler.
3Hren
force-pushed
the
feat/worker/geoip
branch
from
b2386b5
to
057ade7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now Workers are capable to detect the country ISO code where they are located and provide it in status handler.