feat: TTL for servers in Rendezvous #1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously in a client tries to resolve remote server in the Rendezvous and that server is absent - the client is hanged for some period of time. This was reported as inconvenient because if such server has never been published it is meaningless even to try to wait for it. Moreover, when a server is resolved it cleans its announce mapping until the next announce, which causes flapping in the info handler. Now all servers are considered live and will not be removed from the info handle if they are capable to reannounce themselves in ~30s. Otherwise the immediate "no peer found" error will be returned to the client.
3Hren
added
T: feature
3Hren
requested review from
antmat,
zavgorodnii and
nikonov1101
as code owners
nikonov1101
approved these changes
Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously in a client tries to resolve remote server in the Rendezvous and that server is absent - the client is hanged for some period of time. This was reported as inconvenient because if such server has never been published it is meaningless even to try to wait for it.
Moreover, when a server is resolved it cleans its announce mapping until the next announce, which causes flapping in the info handler.
Now all servers are considered live and will not be removed from the info handle if they are capable to reannounce themselves in ~30s. Otherwise the immediate "no peer found" error will be returned to the client.