Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

library: Adds TextView entry #315

Merged
merged 4 commits into from Jun 14, 2023
Merged

library: Adds TextView entry #315

merged 4 commits into from Jun 14, 2023

Conversation

SoNiC-HeRE
Copy link
Contributor

@SoNiC-HeRE SoNiC-HeRE commented Jun 11, 2023

Preview:

Screencast.from.2023-06-11.16-35-36.webm

Closes #277

Apart from cut,copy,select all,clear all and paste functions;
Also added logic for the key bindings:

  • ctrl + C
  • ctrl + V
  • ctrl + X

Also supports direct interaction with mouse selection and backspace key

@SoNiC-HeRE SoNiC-HeRE changed the title Adds TextView Demo library: Adds TextView entry Jun 11, 2023
Copy link
Contributor

@andyholmes andyholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another great one, just some cleanup for formatting and frame around the scrolled window.

src/Library/demos/TextView/main.blp Outdated Show resolved Hide resolved
src/Library/demos/TextView/main.js Show resolved Hide resolved
src/Library/demos/TextView/main.blp Outdated Show resolved Hide resolved
Copy link
Contributor

@andyholmes andyholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once you apply the formatting suggestions.

We really need an auto-formatter, because formatting is important but not something developers should be doing by hand IMO.

src/Library/demos/TextView/main.blp Outdated Show resolved Hide resolved
src/Library/demos/TextView/main.blp Outdated Show resolved Hide resolved
src/Library/demos/TextView/main.blp Outdated Show resolved Hide resolved
src/Library/demos/TextView/main.blp Show resolved Hide resolved
src/Library/demos/TextView/main.js Show resolved Hide resolved
@SoNiC-HeRE
Copy link
Contributor Author

Looks good once you apply the formatting suggestions.

We really need an auto-formatter, because formatting is important but not something developers should be doing by hand IMO.

That'd be really helpful specially when we're dealing with large UI Files

@andyholmes andyholmes merged commit 8a5c509 into main Jun 14, 2023
sonnyp pushed a commit that referenced this pull request Jun 17, 2023
* Added TextView Demo
* Updated JS Code
* Updated Code
* Formatting Changes
sonnyp pushed a commit that referenced this pull request Jun 20, 2023
* Added TextView Demo
* Updated JS Code
* Updated Code
* Formatting Changes
sonnyp pushed a commit to SoNiC-HeRE/Workbench that referenced this pull request Aug 13, 2023
* Added TextView Demo
* Updated JS Code
* Updated Code
* Formatting Changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TextView libray entry
2 participants