library: Adds TextView entry #315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyholmes
requested changes
Jun 12, 2023
Contributor
andyholmes
left a comment
andyholmes
left a comment
There was a problem hiding this comment.
Another great one, just some cleanup for formatting and frame around the scrolled window.
andyholmes
requested changes
Jun 14, 2023
Contributor
andyholmes
left a comment
andyholmes
left a comment
There was a problem hiding this comment.
Looks good once you apply the formatting suggestions.
We really need an auto-formatter, because formatting is important but not something developers should be doing by hand IMO.
Contributor
Author
That'd be really helpful specially when we're dealing with large UI Files |
andyholmes
approved these changes
Jun 14, 2023
sonnyp
pushed a commit
that referenced
this pull request
Jun 17, 2023
* Added TextView Demo * Updated JS Code * Updated Code * Formatting Changes
sonnyp
pushed a commit
that referenced
this pull request
Jun 20, 2023
* Added TextView Demo * Updated JS Code * Updated Code * Formatting Changes
sonnyp
pushed a commit
to SoNiC-HeRE/Workbench
that referenced
this pull request
Aug 13, 2023
* Added TextView Demo * Updated JS Code * Updated Code * Formatting Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview:
Screencast.from.2023-06-11.16-35-36.webm
Closes #277
Apart from cut,copy,select all,clear all and paste functions;
Also added logic for the key bindings:
ctrl + Cctrl + Vctrl + XAlso supports direct interaction with
mouse selectionandbackspace key