library: Add Search entry #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonnyp
reviewed
Jun 22, 2023
There was a problem hiding this comment.
Very cool
And also how do I know if I got no matching results from the search so that I can show a status page for it?
Good question. I guess you store a count that is updated on invalidation and filter
example
let results_count = -1;
fuinction filter(row) {
const match = res.test...
if (match) results_count++
return match
}
searchentry.connect("search-changed", () => {
// using -1 and not 0 so you can differentiate between
// no results and not filtered yet
result_counts = -1;
listbox.invalidate_filter();
});
sonnyp
reviewed
Jun 22, 2023
AkshayWarrier
changed the title
sonnyp
pushed a commit
that referenced
this pull request
Jun 29, 2023
sonnyp
pushed a commit
to SoNiC-HeRE/Workbench
that referenced
this pull request
Aug 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #338
I'd like to know if I implemented the filtering functionality properly or do I need to change something. And also how do I know if I got no matching results from the search so that I can show a status page for it?