library: Add Tooltip entry #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyholmes
approved these changes
Jul 19, 2023
There was a problem hiding this comment.
I think this is all good.
I did encounter some different warnings, but I don't see that you're doing anything incorrect. It seems like the custom tooltip widget doesn't need to be replaced on each query-tooltip emission, but there's no way to query the child widget, so I don't think that's an issue either.
Good job!
sonnyp
pushed a commit
to SoNiC-HeRE/Workbench
that referenced
this pull request
Aug 13, 2023
* library: Add Tooltip entry * Tooltip: Create custom tooltip in code * Tooltip: Minor change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #422
I'm having some trouble with the custom tooltip. It usually works fine the first time, but then occasionally I get these errors and the tooltip stops working.