Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test action #79

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Test action #79

merged 1 commit into from
Sep 11, 2023

Conversation

sonomirco
Copy link
Owner

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 👷 Optimization
  • 📝 Documentation Update
  • 🔖 Release
  • 🚩 Other

Description

This PR [adds/removes/fixes/replaces] this [feature/bug/etc].

Related Tickets & Documents

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 readme
  • 📜 contributing.md
  • 📓 docs
  • 📕 storybook
  • 🙅 no documentation needed

@sonomirco sonomirco added documentation Improvements or additions to documentation duplicate This issue or pull request already exists labels Sep 11, 2023
@sonomirco sonomirco self-assigned this Sep 11, 2023
@sonomirco
Copy link
Owner Author

sonomirco commented Sep 11, 2023

Please complete the following checklist:

Thank you, name, for taking the time to review our project. In order to complete the review process, we kindly request your signoff by filling out this checklist. Thanks again! 🙏

If you did a Code review

  • I've downloaded the code and tested
  • I don't see bugs in the code
  • The code is justifiably easy to read and understand
  • The code meets any acceptance criteria agreed to for the work
  • The code doesn't implement additional and unnecessary functionality
  • There are no linter errors
  • The code follows team unit testing standards
  • The code style and structure follows the project standards as

If you did a Node review

  • I've downloaded the node and tested
  • I don't see bugs in the functionality of the nodes
  • The nodes have all the inputs and outputs required
  • The nodes are well documented

Document review

  • The documentation clearly describes the implementation

@sonomirco sonomirco merged commit faed6be into develop Sep 11, 2023
6 of 9 checks passed
@sonomirco sonomirco deleted the dev/mibi/test-comment-action branch September 11, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant