At least once message guarantee ✌️ #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Use channel to broadcast updated detail 3. Schedule tasks to move messages. 4. At least once message guarantee
# Conflicts: # rqueue-spring-boot-starter/src/test/java/com/github/sonus21/rqueue/spring/boot/integration/ApplicationTest.java # rqueue-spring-boot-starter/src/test/java/com/github/sonus21/rqueue/spring/boot/integration/ApplicationWithAutoStartSchedulerDisabledTest.java # rqueue-spring-boot-starter/src/test/resources/application-disabled.properties # rqueue/src/main/java/com/github/sonus21/rqueue/core/MessageScheduler.java # rqueue/src/main/java/com/github/sonus21/rqueue/listener/RqueueMessageListenerContainer.java
1. multiple tasks were getting submitted due to race concurrent message events 2. Do not cancel already cancelled/done tasks 3. Do not call recursively to execute script => this can lead to error in the local time stored in scheduled tasks 4. Tasks for non-delayed queued were also scheduled RqueueMessageListenerContainer 1. When received message is null => queue is empty sleep for polling interval instead of polling again 2. Do not consider delayed queue workers as they are scheduled separately. push-message.lua Wrong data type was returned leading to error in task scheduling due to null value Added multiple test scenarios to verify different condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.