Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit PathVariable name in queue related endpoints #219

Merged
merged 1 commit into from Mar 1, 2024

Conversation

malkovro
Copy link
Contributor

Description

Using this lib in an updated SpringBoot project works fine except for the exploration of the Queue details in the UI:

In order to prevent having to compile with parameter flag and needing to parse bytecode o deduce the path variable name on the queue related endpoints.

Fixes #218

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

NA

Test Configuration:

  • Spring Version
  • Spring Boot Version
  • Redis Driver Version

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2685

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 24 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.4%) to 91.016%

Files with Coverage Reduction New Missed Lines %
rqueue-core/src/main/java/com/github/sonus21/rqueue/listener/JobImpl.java 1 82.39%
rqueue-core/src/main/java/com/github/sonus21/rqueue/utils/ThreadUtils.java 2 90.38%
rqueue-core/src/main/java/com/github/sonus21/rqueue/listener/MessageContainerBase.java 3 70.0%
rqueue-core/src/main/java/com/github/sonus21/rqueue/listener/PostProcessingHandler.java 3 90.34%
rqueue-core/src/main/java/com/github/sonus21/rqueue/utils/QueueThreadPool.java 4 76.47%
rqueue-core/src/main/java/com/github/sonus21/rqueue/listener/RqueueMessagePoller.java 5 86.11%
rqueue-core/src/main/java/com/github/sonus21/rqueue/core/impl/RqueueMessageTemplateImpl.java 6 91.67%
Totals Coverage Status
Change from base Build 2670: -0.4%
Covered Lines: 5349
Relevant Lines: 5877

💛 - Coveralls

@sonus21 sonus21 merged commit 1ddc6fa into sonus21:master Mar 1, 2024
2 checks passed
@malkovro malkovro deleted the fix/parameter-name-resolution branch March 5, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IllegalArgumentException when accessing queue details
3 participants