Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve coverage test #1031

Merged
merged 3 commits into from Apr 3, 2024
Merged

Improve coverage test #1031

merged 3 commits into from Apr 3, 2024

Conversation

reuvenperetz
Copy link
Collaborator

@reuvenperetz reuvenperetz commented Apr 3, 2024 •
edited

Pull Request Description:

  1. Increase coverage threshold for test success to 96%
  2. Include only model_compression_toolkit files in the report.
  3. Archive an HTML coverage report.
  4. Remove unused files like model_compression_toolkit/core/exporter.py and model_compression_toolkit/core/keras/graph_substitutions/substitutions/remove_relu_upper_bound.py.

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@reuvenperetz reuvenperetz requested a review from ofirgo April 3, 2024 11:15
@reuvenperetz reuvenperetz requested a review from ofirgo April 3, 2024 12:21
@reuvenperetz reuvenperetz merged commit f5786c1 into sony:main Apr 3, 2024
27 checks passed
@reuvenperetz reuvenperetz deleted the covergae branch April 3, 2024 13:19
samuel-wj-chapman pushed a commit to samuel-wj-chapman/model_optimization that referenced this pull request Apr 8, 2024
@reuvenperetz @samuel-wj-chapman
Improve coverage test (sony#1031)
6ee2275 
* Increase coverage threshold for test success to 96%
* Include only model_compression_toolkit files in the report.
* Archive an HTML coverage report.
* Remove unused files like model_compression_toolkit/core/exporter.py and model_compression_toolkit/core/keras/graph_substitutions/substitutions/remove_relu_upper_bound.py.

---------

Co-authored-by: reuvenp <reuvenp@altair-semi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofirgo ofirgo ofirgo approved these changes

Assignees
No one assigned
Labels
auto:core auto:gptq auto:ptq auto:tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@reuvenperetz @ofirgo