Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag to indicate whether to run mixed precision according to resource utilization provided by user. #1052

Merged
merged 6 commits into from May 6, 2024

Conversation

lior-dikstein
Copy link
Collaborator

@lior-dikstein lior-dikstein commented May 1, 2024

Pull Request Description:

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

liord added 2 commits April 30, 2024 16:59
# Conflicts:
#	tests/common_tests/helpers/generate_test_tp_model.py
…ccommodate for the changes in running mixed precision.
Copy link
Collaborator

@ofirgo ofirgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some cosmetic comments.
In addition:

  1. Please add a dedicated test for the new feature (define a setup with TPC that would run mixed precision before the new feature, and verify that it didn't run mixed precision). I would replicate this test for each of the available resource utilization types.
  2. Please update the release notes draft.
  3. Also add a description to the PR with an explanation about the feature (and include it in the commit message when you merge it).

@@ -0,0 +1,80 @@
import numpy as np
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing license

@lior-dikstein lior-dikstein merged commit 109770e into main May 6, 2024
27 checks passed
@lior-dikstein lior-dikstein deleted the requires_mp branch May 6, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants