Logger update #995
Merged
Logger update #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 14, 2024 11:52
Changed all "Logger.error" terms to "Logger.critical". Changed all "Logger.exception" terms to "Logger.critical".
…ed all Logger.error to Logger.critical
eladc-git
reviewed
Mar 14, 2024
model_compression_toolkit/core/common/graph/memory_graph/bipartite_graph.py
Show resolved
Hide resolved
model_compression_toolkit/core/common/hessian/trace_hessian_calculator.py
Outdated
Show resolved
Hide resolved
|
|
||
| self.input_images = fw_impl.to_tensor(input_images) | ||
| self.num_iterations_for_approximation = num_iterations_for_approximation | ||
|
|
||
| # Validate representative dataset has same inputs as graph | ||
| if len(self.input_images)!=len(graph.get_inputs()): | ||
| Logger.error(f"Graph has {len(graph.get_inputs())} inputs, but provided representative dataset returns {len(self.input_images)} inputs") | ||
| Logger.critical(f"The graph requires {len(graph.get_inputs())} inputs, but the provided representative dataset contains {len(self.input_images)} inputs") |
model_compression_toolkit/core/common/mixed_precision/kpi_tools/kpi_methods.py
Outdated
Show resolved
Hide resolved
model_compression_toolkit/core/common/mixed_precision/search_methods/linear_programming.py
Outdated
Show resolved
Hide resolved
Comment on lines
+218
to
+225
| list), f'\'QuantizationConfigOptions\' options list must be a list, but received: {type(quantization_config_list)}.' | ||
| assert len(quantization_config_list) > 0, f'Options list can not be empty.' | ||
| for cfg in quantization_config_list: | ||
| assert isinstance(cfg, OpQuantizationConfig), f'Options should be a list of QuantizationConfig objects, ' \ | ||
| f'but found an object type: {type(cfg)}' | ||
| assert isinstance(cfg, OpQuantizationConfig), f'Each option must be an instance of \'OpQuantizationConfig\', but found an object of type: {type(cfg)}.' | ||
| self.quantization_config_list = quantization_config_list | ||
| if len(quantization_config_list) > 1: | ||
| assert base_config is not None, f'When quantization config options contains more than one configuration, ' \ | ||
| f'a base_config must be passed for non-mixed-precision optimization process' | ||
| assert base_config in quantization_config_list, f"base_config must be in the given quantization config " \ | ||
| f"list of options" | ||
| assert base_config is not None, f'For multiple configurations, a \'base_config\' is required for non-mixed-precision optimization.' | ||
| assert base_config in quantization_config_list, f"\'base_config\' must be included in the quantization config options list." |
model_compression_toolkit/target_platform_capabilities/target_platform/target_platform_model.py
Outdated
Show resolved
Hide resolved
| @@ -87,7 +87,7 @@ def __or__(self, other: Any): | |||
| """ | |||
|
|
|||
| if not isinstance(other, AttributeFilter): | |||
| Logger.error("Not an attribute filter. Can not run an OR operation.") # pragma: no cover | |||
| Logger.critical("Not an attribute filter. Cannot perform an 'OR' operation.") # pragma: no cover | |||
There was a problem hiding this comment.
specify 'other' in the error
| @@ -101,7 +101,7 @@ def __and__(self, other: Any): | |||
| AndAttributeFilter that filters with AND between the current AttributeFilter and the passed AttributeFilter. | |||
| """ | |||
| if not isinstance(other, AttributeFilter): | |||
| Logger.error("Not an attribute filter. Can not run an AND operation.") # pragma: no cover | |||
| Logger.critical("Not an attribute filter. Can not perform an 'AND' operation.") # pragma: no cover | |||
There was a problem hiding this comment.
specify 'other' in the error
...toolkit/target_platform_capabilities/target_platform/targetplatform2framework/current_tpc.py
Outdated
Show resolved
Hide resolved
lior-dikstein
force-pushed
the
logger_update
branch
from
40a7ff6
to
4c77907
Compare
eladc-git
approved these changes
Mar 21, 2024
added 2 commits
March 21, 2024 09:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description:
Checklist before requesting a review: