Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove git submodule foreach git checkout master #133

Merged
merged 1 commit into from
Apr 5, 2021

Conversation

kamtom480
Copy link
Contributor

sdk/apps submodule has no branch master and this command is not needed.

@kamtom480
Copy link
Contributor Author

@takayoshi-k @Shunichi-K @KazuyaHioki @TomonobuHayakawa @ssk-to Could you please review it and merge it?

@SPRESENSE
Copy link
Collaborator

Dear @kamtom480 san

Thank you very much for your contribution!
We are now using a "develop" branch for developing, and it will be merged to master branch in next release.

Could you change base branch to develop from master?

@kamtom480 kamtom480 changed the base branch from master to develop March 30, 2021 14:49
SPRESENSE
SPRESENSE previously approved these changes Apr 5, 2021
Copy link
Collaborator

@SPRESENSE SPRESENSE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear @kamtom480 san,

Thank you for changing a target branch to develop.
Your change is good fo us, thank you.

We will merge this PR soon.

@SPRESENSE SPRESENSE merged commit 92d9f8f into sonydevworld:develop Apr 5, 2021
@SPRESENSE SPRESENSE added this to the v2.2.0 milestone Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants