examples/dsc: add card detection via FS automount driver #536
Conversation
Merge develop into master for v2.6.0 release
Signed-off-by: Petro Karashchenko <petro.karashchenko@gmail.com>
pkarashchenko
force-pushed
the
fs_automount
branch
from
26c66df
to
7eecdcf
Compare
| * | ||
| * Description: | ||
| * Finalize file utility | ||
| ****************************************************************************/ | ||
|
|
||
| void futil_finalize(void) | ||
| void file_finalize(void) | ||
| { | ||
| sem_destroy(&g_sem); |
There was a problem hiding this comment.
I'm not sure if now g_sem is needed at all with FS automounter.
|
@pkarashchenko Thanks for your contribution. $ . /tools/configure.sh spresense:nsh_automount
Could you please check these issues? |
|
Sure. Thank you for checking. I will take a look. One question from my side is how did you measure the time till the NSH prompt appears? Can that be easily noticed visually? Or you instrumented code and added some timestamp prints? |
|
@SPRESENSE also one question from my side: is it slower when there is no card during bootup or it does not depend if the card is inserted during boot or not? |
|
I was able to reproduce and fix both issues. My understanding of spresense PIO level was messed up so I spend few hours of educating myself via browsing the source code :) |
|
@SPRESENSE please try the new PR to NuttX mainline. I hope issues to be resolved. Anyway those improvements are mostly for the case when board boots with no SD card. When SD card is inserted or is in the slot during the boot process it still needs around a second to settle down and set |
|
@pkarashchenko san |
|
Done |
|
@pkarashchenko san I have checked this application with the latest NuttX, but it doesn't work well. Regardless of whether CONFIG_FS_AUTOMOUNTER_DRIVER is enabled or not, the LCD display freezes when the SD card is removed or inserted. After investigating the cause, I found that if I revert the following commits, it works correctly. I will merge it because they have nothing to do with this PR. Thanks. |
|
@SPRESENSE thank you. I made a test as you pointed out by copy example app and running it on top of example camera. But maybe it was before the PR that you specify. I added print in the place where automount signal is received by the app and it was working as expected. Let's follow-up to fix the other regression. |
|
@SPRESENSE are there any other apps that should be updated? I'm think of the path to get board callback removed from the NuttX repo. I think that some defconfigs should be updated to use automount now. I would appreciate if you can give me some high level overview on what are next steps. |
No description provided.