[TONE] audio_policy: Migrate to bluetooth.audio@2.0 HAL policy #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will reduce duplication when the new audio HAL and A2DP offloading come online, that both require duplication of the toplevel audio policy file extended with the appropriate routes. Signed-off-by: Marijn Suijten <marijns95@gmail.com>
This is a convenience commit that contains a pure copy of audio_policy_configuration.xml. Actual modifications to our audio configuration will be done in a separate commit, making the changes much more obvious. The fallback policy is used to circumvent bluetooth.audio@2.0. While no issues are expected nor found during prolonged testing (+/- one year) AOSP provides this feature and we might as well use it. The legacy HAL can be used by setting: persist.bluetooth.bluetooth_audio_hal.disabled=true See the policy selection changes for more info: https://android.googlesource.com/platform/frameworks/av/+/e598545cb84723da4878c503ac54ca1426fa920b Signed-off-by: Marijn Suijten <marijns95@gmail.com>
The audio.bluetooth.default.so audio module, configured by bluetooth_audio_policy_configuration.xml, utilizes the new HAL-based mechanism to register a BT audio endpoint and transfer audio data. Update our policy to route audio properly to this module, while retaining a2dp input compatibility through the old mechanism. See the identical change in crosshatch: https://android.googlesource.com/device/google/crosshatch/+/c05ccdbed6c7c74d450e7149969c6c3431155628 audio_policy_configuration_bluetooth_legacy_hal.xml remains unchanged to reflect the old variant of the system (using sockets between the BT stack and audioserver), usable with persist.bluetooth.bluetooth_audio_hal.disabled=true. NOTE: This relies on device-sony-common to add the new files to PRODUCT_COPY_FILES. Signed-off-by: Marijn Suijten <marijns95@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The audio.bluetooth.default.so audio module, configured by
bluetooth_audio_policy_configuration.xml, utilizes the new HAL-based
mechanism to register a BT audio endpoint and transfer audio data.
Update our policy to route audio properly to this module, while
retaining a2dp input compatibility through the old mechanism.
See the identical change in crosshatch:
https://android.googlesource.com/device/google/crosshatch/+/c05ccdbed6c7c74d450e7149969c6c3431155628
audio_policy_configuration_bluetooth_legacy_hal.xml remains unchanged to
reflect the old variant of the system (using sockets between the BT
stack and audioserver), usable with
persist.bluetooth.bluetooth_audio_hal.disabled=true.
NOTE: This relies on device-sony-common to add the new files to
PRODUCT_COPY_FILES.