Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest update on LA.UM.6.4.r1 broke compilation #1997

Closed
Thaodan opened this issue Jun 1, 2019 · 8 comments · Fixed by mer-hybris/android_kernel_sony_msm#29
Closed

Latest update on LA.UM.6.4.r1 broke compilation #1997

Thaodan opened this issue Jun 1, 2019 · 8 comments · Fixed by mer-hybris/android_kernel_sony_msm#29

Comments

@Thaodan
Copy link

Thaodan commented Jun 1, 2019

The latest update to LA.UM.6.4.r1 brought the commit:
e5d7620

Which results in

../../../../../../kernel/sony/msm-4.4/kernel/drivers/platform/msm/ipa/ipa_v3/ipa_rt.c: In function 'ipa3_reset_rt':
../../../../../../kernel/sony/msm-4.4/kernel/drivers/platform/msm/ipa/ipa_v3/ipa_rt.c:1473:13: error: 'struct ipa3_rt_entry' has no member named 'rule_id_valid'
    if (!rule->rule_id_valid)
             ^
make[6]: *** [drivers/platform/msm/ipa/ipa_v3/ipa_rt.o] Error 1
make[6]: *** Waiting for unfinished jobs....

The issue is that /rule_id_valid/ was only added in:
d0c2a1e

Which is not inside this true.
So what should happen revert the commit or apply depended commit?

@jerpelea
Copy link
Collaborator

jerpelea commented Jun 3, 2019

please add the missing commit and PR

@Thaodan
Copy link
Author

Thaodan commented Jun 3, 2019 via email

@Thaodan
Copy link
Author

Thaodan commented Jun 3, 2019 via email

@kholk
Copy link
Contributor

kholk commented Jun 3, 2019

@Thaodan Revert the commit. It's the best choice since k4.4 is in feature freeze since... A very long time ago.
The commit that introduces the fix also introduces a new feature, which will never be used anyway ;)

@Thaodan
Copy link
Author

Thaodan commented Jun 3, 2019 via email

@jerpelea
Copy link
Collaborator

jerpelea commented Jun 3, 2019

Please rever the commit
the branch is feature freeze

Thaodan added a commit to Thaodan/android_kernel_sony_msm that referenced this issue Jun 3, 2019
- This reverts commit e5d7620
- Fixes sonyxperiadev#1997 :: The feature mentioned isn't aviable anyway in 4.4.x
@Thaodan
Copy link
Author

Thaodan commented Jun 4, 2019

This depends also partly #1998.

@Thaodan
Copy link
Author

Thaodan commented Jun 14, 2019

Fixed by: 08932cb

@Thaodan Thaodan closed this as completed Jun 14, 2019
Thaodan added a commit to Thaodan/android_kernel_sony_msm that referenced this issue Jun 14, 2019
…0206_upstream_updates

- Fixes sonyxperiadev#1997
- Add the ability to the revert display panel firmware
  (SOnyxperiadev Pull sonyxperiadev#2007)
Thaodan added a commit to Thaodan/android_kernel_sony_msm that referenced this issue Jun 14, 2019
…0206_upstream_updates

- latest updates from stable 4.4.y
- Fixes sonyxperiadev#1997
- Add the ability to the revert display panel firmware
  (SOnyxperiadev Pull sonyxperiadev#2007)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants