[2.3.2.r1] Revert "usb: gadget: f_mtp: Increase default TX buffer size" #2059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 00d171a. Signed-off-by: Pavel Dubrova <pashadubrova@gmail.com>
|
I would agree with you if future devices needed this commit, and I definitely agree that fixing that in the kernel is generally a better and cleaner way, but it's legacy devices the ones needing it. Let it get fixed the userspace way... Or this one will backfire on us on future devices because, if we merge this, then we will have to apply a fix for Tama and Kumano (the latter only on 4.14), plus anytime a new platform gets out. You understand the point, right? |
|
please fix it in userspace for legacy devices |
|
Let's fix it in userspace 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix this issue: sonyxperiadev/bug_tracker#432 (comment)