[7.1.r1] msm: camera: actuator: Fix range for BU64747 actuator #2118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sraase I don't know whether that was already known or not, but this appears Tagging you to make you aware of the issue again. |
The actuator has a sensible range of 200-800, where 800 is for near subjects and 200 is "infinity". Address the userspace framework issues with the actuator range by normalizing the incoming position request data in the supported range.
kholk
force-pushed
the
71r1_camx_actuator
branch
from
9f3e45c
to
6dca64a
Compare
|
The actual drivers have not changed between CamX versions, so I did not expect any change in behaviour. I hope to be able to investigate this in more detail in the near future. |
Thaodan
suggested changes
Dec 4, 2019
kholk
force-pushed
the
71r1_camx_actuator
branch
from
2b2c6f1
to
6dca64a
Compare
|
for now we add the patch while a solution is investigated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actuator has a sensible range of 200-800, where 800 is
for near subjects and 200 is "infinity".
Address the userspace framework issues with the actuator range
by normalizing the incoming position request data in the
supported range.
NOTE: THIS IS A WORKAROUND - MOSTLY THE SAME THAT I
PUSHED FOR KERNEL 4.9 BASED BSPs.
THIS IS NOT THE SOLUTION (but myopia stops, so feel free
to use it while the camera userspace gets properly fixed/calibrated).