ADD :: 리뷰 반영 (#56)

soolung · Mar 18, 2023 · 3486136 · 3486136
1 parent 0d3aa34
commit 3486136
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/main/java/com/soogung/simblue/domain/application/presentation/ApplicationController.java b/src/main/java/com/soogung/simblue/domain/application/presentation/ApplicationController.java
@@ -87,7 +87,7 @@ public void deleteApplication(@PathVariable Long id) {
         deleteApplicationService.execute(id);
     }
 
-    @GetMapping("/{id}/close")
+    @PutMapping("/{id}/close")
     public void closeApplication(@PathVariable Long id) {
         closeApplicationService.execute(id);
     }

diff --git a/src/main/java/com/soogung/simblue/domain/application/service/CloseApplicationService.java b/src/main/java/com/soogung/simblue/domain/application/service/CloseApplicationService.java
@@ -12,17 +12,20 @@
 import lombok.RequiredArgsConstructor;
 import org.springframework.stereotype.Service;
 
+import javax.transaction.Transactional;
+
 @Service
 @RequiredArgsConstructor
 public class CloseApplicationService {
 
+    private final UserFacade userFacade;
     private final ApplicationFacade applicationFacade;
     private final OwnerRepository ownerRepository;
-    private final UserFacade userFacade;
 
+    @Transactional
     public void execute(Long id) {
         Teacher teacher = userFacade.getCurrentTeacher();
-        Application application = applicationFacade.findApplicationById(id);
+        Application application = applicationFacade.getSimpleApplication(id);
         application.validateStatus();
         application.validatePermission(ownerRepository, teacher.getId());