Feat/bsmOauth #82

chaewu · 2023-04-04T06:00:26Z

📄 Summary

BsmOauth를 통한 회원가입 및 로그인 기능 구현

🔨 Tasks

Bsm 서비스를 통한 학생 및 선생님 로그인과 회원가입

🙋🏻 More

Google Oauth 로그인 및 회원가입 로직 수정

gimhanul

보완점

해당 PR 관련 이슈 BSM OAuth #66 잘 읽어보시고 빠진 부분 보완해주세용(BSM 연동, BSM service link 꺼내오기 등등)
CI details 확인 후 failed 고쳐주세요
서비스는 다 분리해서 작성해주세요(BSM Service 하나에 다 박혀있음)

핢 말

전체적으로 코드를 갈아 엎으신 것 같은데 이런 사소한 사소한 변경들 곤란합니다 (심청이는 이미 서비스중이라서, 프론트에서 사소한 변경점을 다 고치기 힘듭니다)
~~왜 하셨나요? 같은 리뷰는 고치라는 뜻이 아닙니다. 진짜 궁금해서 물어보니까 답변해주세용

gimhanul · 2023-04-04T06:54:26Z

src/main/java/com/soogung/simblue/domain/auth/domain/AuthId.java

+package com.soogung.simblue.domain.auth.domain;
+
+
+import lombok.*;


wildcard 사용은 지양합니다

관련 글 읽어보시고 수정해주세요
이곳말고 다른 곳도!~

gimhanul · 2023-04-04T06:56:28Z

src/main/java/com/soogung/simblue/domain/auth/domain/RefreshToken.java

+    public RefreshToken update(final String refreshToken, final long ttl) {
+        this.refreshToken = refreshToken;
+        this.ttl = ttl;
+        return this;


refresh token이 수정되어야 하는 이유는?

gimhanul · 2023-04-04T06:57:06Z

src/main/java/com/soogung/simblue/domain/auth/domain/RefreshToken.java

    @Id
-    private String token;
+    private String id;
+
+    private String refreshToken;


굳이 id를 따로 두는 이유는 무엇인가요? refresh token도 충분히 unique할텐데용

gimhanul · 2023-04-04T06:57:17Z

src/main/java/com/soogung/simblue/domain/auth/domain/RefreshToken.java

+
+    private String refreshToken;
+
+    private String role;


role을 저장하는 이유는 뭔가요?

gimhanul · 2023-04-04T06:58:16Z

src/main/java/com/soogung/simblue/domain/auth/presentation/AuthController.java

+    public BsmTokenResponse userSignup(HttpServletRequest request) throws IOException {
+        return loginService.execute(request.getHeader("authCode"));


헤더를 꺼내오고 싶은 거면 @RequestHeader annotation을 사용해서 가져올 수 있는 걸로 알고있습니당

gimhanul · 2023-04-04T07:45:26Z

src/main/java/com/soogung/simblue/global/security/jwt/JwtProperties.java

+@Getter
+@ConstructorBinding
+@ConfigurationProperties(prefix = "jwt")
+public class JwtProperties {
+    private final String header;
+    private final String secret;
+    private final Long accessExp;
+    private final Long refreshExp;
+    private final String prefix;
+
+    public JwtProperties(String header, String secret, Long accessExp, Long refreshExp, String prefix) {
+        this.header = header;
+        this.secret = secret;
+        this.accessExp = accessExp;
+        this.refreshExp = refreshExp;
+        this.prefix = prefix;
+    }
+
+}
+


이미 있습니다

gimhanul · 2023-04-04T07:46:06Z

src/main/java/com/soogung/simblue/global/security/jwt/JwtTokenProvider.java


-    public String createAccessToken(String email) {
-        return createToken(email, jwtProperties.getAccessTime());
+        return jwtProperties.getPrefix() + EMPTY.getMessage() + generateToken(authId, role, ACCESS_KEY.getMessage() ,jwtProperties.getAccessExp());


prefix를 왜 붙여서 주는지

gimhanul · 2023-04-04T07:47:23Z

src/main/resources/application.yml

+  secret: ${JWT_SECRET}
+  accessExp: 3600000
+  refreshExp: 2592000000
+  prefix: Bearer
+
+
+#  refresh-time: 2592000000 # 30일
+#  access-time: 3600000 # 1시간
+#  prefix: Bearer
+#  header: Authorization
+#  secret-key: ${JWT_SECRET}


있는 걸 왜 바꾸는지?

gimhanul · 2023-04-04T07:47:41Z

src/main/resources/application.yml

+  jpa:
+    hibernate:
+      ddl-auto: validate


validate는 local환경에서 사용하지 않ㄴ습니다

gimhanul · 2023-04-04T07:48:07Z

src/main/java/com/soogung/simblue/global/security/jwt/filter/JwtAuthenticationFilter.java


+    @Override
+    protected void doFilterInternal(@NotNull HttpServletRequest request, @NotNull HttpServletResponse response, FilterChain filterChain) throws ServletException, IOException {


request와 response에 null이 들어오는 경우가 있나요?

chaewoo1002 and others added 3 commits April 4, 2023 09:37

FEAT :: Bsm 로그인 / 회원가입 기능 추가

4399236

Merge branch 'develop' into feat/bsmOauth

6ff2e5c

FIX :: 버그 fix

299b3c4

chaewu requested a review from a team as a code owner April 4, 2023 06:00

chaewu added the ✨ Feature 새로운 기능 개발 label Apr 4, 2023

gimhanul requested changes Apr 4, 2023

View reviewed changes

chaewu closed this Apr 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/bsmOauth #82

Feat/bsmOauth #82

chaewu commented Apr 4, 2023

gimhanul left a comment •

edited

gimhanul Apr 4, 2023

gimhanul Apr 4, 2023

gimhanul Apr 4, 2023

gimhanul Apr 4, 2023

gimhanul Apr 4, 2023

gimhanul Apr 4, 2023

gimhanul Apr 4, 2023

gimhanul Apr 4, 2023

gimhanul Apr 4, 2023

gimhanul Apr 4, 2023

		package com.soogung.simblue.domain.auth.domain;


		import lombok.*;

		public BsmTokenResponse userSignup(HttpServletRequest request) throws IOException {
		return loginService.execute(request.getHeader("authCode"));


		@Override
		protected void doFilterInternal(@NotNull HttpServletRequest request, @NotNull HttpServletResponse response, FilterChain filterChain) throws ServletException, IOException {

Feat/bsmOauth #82

Feat/bsmOauth #82

Conversation

chaewu commented Apr 4, 2023

📄 Summary

🔨 Tasks

🙋🏻 More

gimhanul left a comment • edited

Choose a reason for hiding this comment

보완점

핢 말

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gimhanul left a comment •

edited