fix: does not modify the data if the type does not change

soosyze · Jul 26, 2022 · c2af335 · c2af335
1 parent fc79e7b
commit c2af335
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/Schema.php b/src/Schema.php
@@ -533,8 +533,18 @@ protected static function modify(
         Field $field,
         array &$tableData
     ): void {
+        $oldField = $table->getField($field->getName());
+
         $table->addField($field);
 
+        /**
+         * Si la modification ne concerne pas le type, la mise à jour des données ne se fait pas.
+         * Exemple: rendre un champ nullable ne doit écraser les données présentent en table.
+         */
+        if ($oldField::TYPE === $field::TYPE) {
+            return;
+        }
+
         $increment = $field instanceof IncrementType
             ? 0
             : null;

diff --git a/tests/unit/SchemaJsonTest.php b/tests/unit/SchemaJsonTest.php
@@ -275,14 +275,15 @@ public function testAlterTableRename(): void
     public function testAlterTableModify(): void
     {
         $this->bdd->alterTable('test_second', static function (TableAlter $table): void {
+            $table->string('value_s')->nullable()->modify();
             $table->float('value_i')->valueDefault(1.0)->modify();
         });
 
         self::assertEquals(
             [
                 'fields'     => [
                     'value_i' => [ 'type' => 'float', 'default' => 1.0 ],
-                    'value_s' => [ 'type' => 'string', 'length' => 255 ]
+                    'value_s' => [ 'type' => 'string', 'length' => 255, 'nullable' => true ]
                 ],
                 'increments' => null
             ],